examples: fix mypy errors in example entry points; add local type-check script (#1091) #1248
Conversation
examples/custom_output_files/main.py
Outdated
| @cocoindex.op.function() | ||
| def markdown_to_html(text: str) -> str: | ||
| return _markdown_it.render(text) | ||
| return cast(str, _markdown_it.render(text)) |
There was a problem hiding this comment.
I'm thinking about also considering code simplicity/readability. Given these examples are for users to understand how to use cocoindex, this matters.
For case like this, it's essentially the underlying library doesn't have a specific type, and the return type of the current function is clear.
I think we can just ignore it by a comment like # type: ignore
(IMO cast(...) is more useful for values within a function - from the point on, the type is clear)
There was a problem hiding this comment.
Please resolve this comment and avoid cast(...) for function return types, and use # type: ignore comment instead. Thanks!
…s, minimal ignores)
|
is it fine this time? |
Hi @samojavo, please resolve the first comment above. Thanks! |
2 participants
• Make all example entry points pass mypy when run individually (with --ignore-missing-imports).
• Add a small helper script (dev/mypy_check_examples.ps1) and a brief note in dev/README.md.
Closes #1091